Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify client to interface type #4

Merged
merged 2 commits into from
Jul 5, 2022
Merged

modify client to interface type #4

merged 2 commits into from
Jul 5, 2022

Conversation

Patrick0308
Copy link
Collaborator

@Patrick0308 Patrick0308 commented Jul 5, 2022 •
edited
Loading

Use client interface instead of struct. Support for users can mock this client.
This is a broken change.

@Patrick0308 Patrick0308 requested a review from sunfuze July 5, 2022 07:58
@sunfuze
Copy link
Contributor

sunfuze commented Jul 5, 2022

这个要升个版本了，release 可以加上 breaking change 的内容

@Patrick0308 Patrick0308 changed the title add client interface modify client to interface type Jul 5, 2022
@Patrick0308 Patrick0308 merged commit 4f3dabe into longportapp:main Jul 5, 2022
@Patrick0308 Patrick0308 deleted the feat-use-interface branch July 5, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfuze sunfuze sunfuze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Patrick0308 @sunfuze