Extension to AuthController fails to "use" custom User entity & model

[fefo-p]

Maybe it's my ignorance, but I'm trying to extend AuthController so it can use my custom versions of User Entity and Model.

I cannot make it work unless I comment out the lines that use Myth\Auth\Entities\User and Myth\Auth\Entities\UserModel from the original AuthController.

Anyone know how to achieve this?

Link to Images describing the code down here:

Controller
Routes
Model

[fefo-p]

BTW, I'm using:

• yesterday's myth-auth code (2020-03-25)
• CI 4.0.2
• apache 2.4.41
• PHP 7.3.8
• macOS 10.15.4

[agungsugiarto]

Why need to extend if you can publish to your app. Just publish controller, entity, model and do what you want.

php spark auth:publish

[MGatner]

I prefer extending as well, because you keep upstream updates without having to re-publish and trying to merge changes.

Your extension won’t work like you are thinking. The “use” statements don’t “extend” as well, you would actually need to implement them. AuthController currently doesn’t use the “model()” function to make this easy, but it would be a quick PR.

[fefo-p]

Thanks to you both. I'm with MGatner on this one.
I think the quickest way will be for me to copy the entire Controller onto \App\Controllers and change the specified lines. At least until this can get sorted out.
Thanks again!

[MGatner]

@fefo-p I would be in favor of leaving this open as a reminder to switch the module to use the model() helper instead, to facilitate extensions.

[fefo-p]

Sure, no prob.

[lonnieezell]

Hey all - I've updated the code to use the model(). Please give it a go in your environments and make sure it works. Trying to get ready to push another beta out and didn't want this to break it without my realizing. Thanks!

[yassinedoghri]

Hi @lonnieezell, I'm currently diving into the code of myth-auth, and must I say I'm learning quite a lot ^^

I have a silly question following this issue, and the refactor you've made by using the model() helper for the UserModel to facilitate extensions (as suggested by @MGatner):

• wouldn't it be best if all of the instanciated models were so using the model() helper? (to ease any extension for GroupModel, PermissionModel and LoginModel).

I've had a need to overwrite the PermissionModel and UserModel instanciated in the services. So I had to change my App\Config\Services by copy/pasting the authentication and authorization services from myth-auth, so I can replace the models with my own (not sure if it's the right way to do it though).