Filter post data on registration #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGatner
approved these changes
May 10, 2020
There was a problem hiding this comment.
Yikes, that’s a great point. This is an urgent security issue @lonnieezell, can we get a hotfix release?
lonnieezell
reviewed
May 11, 2020
|
@michalsn Good catch. Thanks! Once my one comment has been addressed I'll merge and release a new beta. @MGatner The only catch is that a recent change requires an app to use the dev branch of CI4 to work, but I'll make the changelog so that they know how to fix the critical bug on their own if they cannot upgrade. |
|
@michalsn Nice add with the personalFields. I had forgotten about those. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should filter data we pass to the User entity during registration since otherwise someone could send additional
POSTdata likeactiveand bypass the need of the account activation.