Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace findWhere #55

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Replace findWhere #55

merged 2 commits into from
Jun 27, 2019

Conversation

MGatner
Copy link
Collaborator

@MGatner MGatner commented Jun 27, 2019

FlatAuthorization still had a few references to the deprecated findWhere. This PR replaces them with where()->first().

@MGatner
Copy link
Collaborator Author

MGatner commented Jun 27, 2019

Note that my initial commit was failing tests because FlatAuthorization assumes returned group results are objects. Rather than update the file I chose to update the GroupModel to be more consistent with the other models (e.g. UserModel returns an entity).

@lonnieezell lonnieezell merged commit 1113263 into lonnieezell:develop Jun 27, 2019
@MGatner MGatner deleted the replace-findwhere branch June 27, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGatner @lonnieezell