Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat make smarter #69

Open
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

waziers
Copy link
Contributor

@waziers waziers commented Aug 1, 2024

  • generation JSON output from Gemini instead of the URL so we can combine the different outputs
  • Add jest for testing the generation of the various components of the url. Currently only works with the Cloud Function endpoint
  • Split the visualization and filter parameter generation into separate calls to be built and tested separately
  • Zero-example filter and visualization generation using the documentation
  • Supply the documentation to Gemini in Mardkown
  • build the explore URL in JS instead of relying on Gemini (which might hallucinate)
  • validate the filters using explicit rules
    • don't include filters for unknown fields
    • don't include filter values that don't validate (they are hallucinations)
  • tests for filter value validation

Todo:

  • add more test coverage for filter and visualization generation
  • include visualization config in final output
  • add support for the bigquery backend in test mode by instantiating the looker SDK in jest
  • create better URL validation to prevent 404 on the page. The URL should always load, even if it has some mistakes.

@waziers waziers requested a review from a team as a code owner August 1, 2024 20:07
Copy link

google-cla bot commented Aug 1, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants