Add GetContractEvent to DAppChainRPCClient #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathornteng
changed the title
phoorichet
reviewed
May 24, 2019
| func (c *DAppChainRPCClient) GetContractEvents(fromBlock, toBlock uint64) (ptypes.ContractEventsResult, error) { | ||
| params := map[string]interface{}{ | ||
| "fromBlock": strconv.FormatUint(fromBlock, 10), | ||
| "toBlock": strconv.FormatUint(toBlock, 10), |
There was a problem hiding this comment.
I think we also need contract as another parameter since contractevents has it. It can be blank string if we don't want to filter by contract name.
There was a problem hiding this comment.
We also need another method to query the block height to really get rid of those JSONRPC client that we're currently using.
func (c *DAppChainRPCClient) GetBlockHeight() (uint64, error)
There was a problem hiding this comment.
contract parameter does not work though. I think we need to have a fix for it.
There was a problem hiding this comment.
Yeah. The name might be mapped incorrectly in loomchain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
GetContractEventsmethod toDAppChainRPCClient. This method returns the list of events from a specified block range.uint64andint64are converted to json string according to https://developers.google.com/protocol-buffers/docs/proto3#json. This causesjson.Unmarshalfail to unmarshal json back to Go struct. So we need to have customjsontagfor int64/uint64 fields.