Check Process limit on node start up #1503
Conversation
cmd/loom/loom.go
Outdated
| return err | ||
| } | ||
| if rlimit.Cur < min { | ||
| return errors.New("insufficient file descriptor") |
There was a problem hiding this comment.
Change this line to
return fmt.Errorf("Current file descriptor limit (%d) is too low; minimum file descriptor limit is %d", rlimit.Cur, min)
config/config.go
Outdated
| CallEnabled: true, | ||
| DPOSVersion: 3, | ||
| AllowNamedEvmContracts: false, | ||
| MinimumFileDescriptorLimit: 512, |
There was a problem hiding this comment.
Not sure 512 is enough but 500000 is definitely not practical.
There was a problem hiding this comment.
500k is what we use on all our nodes, and what we instruct people to use in the jump-start docs. 500k might be overkill, lets set the minimum to 100k.
config/config.go
Outdated
| CallEnabled: true, | ||
| DPOSVersion: 3, | ||
| AllowNamedEvmContracts: false, | ||
| MinimumFileDescriptorLimit: 512, |
There was a problem hiding this comment.
500k is what we use on all our nodes, and what we instruct people to use in the jump-start docs. 500k might be overkill, lets set the minimum to 100k.
config/config.go
Outdated
| @@ -141,6 +141,9 @@ type Config struct { | |||
|
|
|||
| // Dragons | |||
| EVMDebugEnabled bool | |||
|
|
|||
| //Minimum number of file descriptor limit | |||
cmd/loom/loom.go
Outdated
| @@ -337,6 +337,13 @@ func newRunCommand() *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "run [root contract]", | |||
| Short: "Run the blockchain node", | |||
| PreRunE: func(cmd *cobra.Command, args []string) error { | |||
| if err := checkFileDescriptorLimit(cfg.MinimumFileDescriptorLimit); err != nil { | |||
There was a problem hiding this comment.
Need to check cfg was actually parsed successfully before attempting to use it. Just move this code to RunE below.
There was a problem hiding this comment.
And skip the limit check if MinimumFileDescriptorLimit == 0
ref : #1495