Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace commas with periods in speech output #287

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

bjorkert
Copy link
Contributor

Replace commas with periods in speech output to ensure clarity for users with commas as decimal separators, since commas are interpreted as pauses rather than spoken.

@bjorkert bjorkert requested a review from marionbarker April 27, 2024 17:52
@bjorkert bjorkert changed the base branch from main to dev April 27, 2024 17:52
@marionbarker
Copy link
Collaborator

Code review looks ok and builds fine. My ear cannot tell the difference. Merging into dev.

@marionbarker marionbarker merged commit bf42d55 into dev Apr 28, 2024
@marionbarker marionbarker deleted the speech-number-formatting branch April 28, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants