Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset topbg for each cycle #307

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Reset topbg for each cycle #307

merged 1 commit into from
Jun 24, 2024

Conversation

bjorkert
Copy link
Contributor

@bjorkert bjorkert commented Jun 24, 2024 •
edited
Loading

An attempt to solve #121

@bjorkert bjorkert requested a review from marionbarker June 24, 2024 18:42
@marionbarker
Copy link
Collaborator

Refer to #121 (comment)
This indicated that user had to restart the app to get the scaling to restore.

Test by add and then remove fake glucose (of 399):

  • LoopFollow showed the fake glucose and autoscaled
  • Removed the fake glucose and the scaling updated without needing to touch the app

lf-pr307-reset-scale

marionbarker
marionbarker approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review looks good. Test was successful.

@marionbarker marionbarker merged commit 02a7167 into dev Jun 24, 2024
@marionbarker marionbarker deleted the topbg branch July 11, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marionbarker marionbarker marionbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjorkert @marionbarker