-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trio remote control #328
Trio remote control #328
Conversation
StatusSuccess CommentsThis comment only covers the Trio 0.2.2 portions of this interface between LoopFollow and Trio. LoopFollow interacts with TempTargets for Trio 0.2.2 using the new Remote icon on the main screen toolbar. No other remote features using LoopFollow as entry mechanism are available using this branch with Trio 0.2.2. RequestsI think the LoopFollow, Settings, Remote Settings screen needs some information included on screen. Remote Type shows as None, Nightscout or Trio Remote Control Possible words to add:
Test Summary ResultsChanges update quickly to plots for LoopFollow (LF), Nightscout (NS) and Trio phone except for the LF Info Table which is fed from the OpenAPS pill. The OpenAPS pill updates with the next cycle, and then the LF Info Table updates. I believe this is expected behavior but needs to be explained in the LoopFollow remote documentation. Remote Settings Choices
Tests with Nightscout OptionAll these test were successful and behaved as expected:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments. IMO, this can be merged to dev (for Trio 0.2.2 use) without modification although I think the added information on the Remote Settings page would be helpful.
@marionbarker, just pushed "Instructions for Remote Type options". |
StatusSuccessful test for Trio 0.2.2 on "looper's" phone Configuration
Tests for Trio 0.2.0Message on LoopFollow Settings Remote Control
From LoopFollow send temp target commands to Trio phone
From Trio phone, apply temp target and override
|
…y, -id and teamId values.
Status:Success when credentials are correct, remote commands from LoopFollow to Trio work
The testing of credentials will be done in another comment. ConfigurationLF phone is iPhone 8 running iOS 16
Trio phone is iPhone SE running iOS 18.1
TestsRemote commands to Trio from LoopFollowDefine success as command is seen on Trio phone and Nightscout display and echoed back appropriately to LF phone (target changes are not seen in the Information Table untl the next cycle, but show up promptly after a refresh on the plot) Set 1:
Set 2
|
StatusThe Browser Build for Trio does not seem to work. Test build source for TrioDetermine if the remote control works from the same LoopFollow phone using different build methods.
|
StatusMy credential tests were successful. Warning - another user reports he is still having trouble with his credentials. Update since last testThe Browser Build method for Trio-dev (private repo) was updated. It now has the correct value for The Mac-Xcode build method for Trio-dev (private repo) was updated. It now has correct value for Build using this new version and see what it takes to update or remove valid credentials from the LoopFollow-Trio phone pair. Configuration
TestingThe initial state was that all remotes were all working. Credential Test 1Install an old version of the browser build that should fail because
Credential Test 2Build with Xcode (same
|
Status SummaryThese are items that I noted need to be fixed before this can be merged to Credential Issues
LoopFollow Issues
|
Status:The earlier tests were all done with the Trio phone unlocked. Configuration
Test 1 - phone recently lockedPerformed 2024-11-19:
Test 2 - phone locked more than one hourPerformed 2024-11-19:
Evaluate on Trio:open Trio phone
|
Remote Control for Trio 1.0
In LoopFollow, a new option is introduced in Remote Settings: Trio Remote Control.
This new Remote Control features Apple Push Notifications in order to deliver remote commands to Trio.
You will need to enter a shared secret (Available in Trio), your APNS Key ID and APNS Key.
There are also guardrails available for bolus, carbs, protein and fat.
In the remote tab, you can use Meal for sending remote carbs/fat/protein. Bolus for remote bolusing. Temp Target for setting a temp target (or set up preset temp targets that are locally in your LoopFollow) or use Overrides (defined in Trio).
When sending a command, you will get a message indicating if the sending is a success or not. This does not mean that Trio has acted on the command. Depending on many factors, it can take from seconds (if the app is open, good network coverage) or many minutes (if the phone is used for playing games that takes lots of resources). Trio will accept a message that is up to 10 minutes old, after that it will be rejected. Trio will also reject a bolus or carbs command if there was other boluses or carbs entries created after the command was created, in order to avoid overdosing. If Trio rejects a command, it will be logged as a Note-entry, visible in LoopFollow and Nightscout.