Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put Silence Pod and Pod Diagnostics behind build-time flag #4

Merged

Conversation

marionbarker
Copy link

  • supports Loop by using DEBUG_FEATURES_ENABLED flag
  • make suspend message more generic

* supports Loop by using DEBUG_FEATURES_ENABLED flag
* make suspend message more generic
@marionbarker
Copy link
Author

marionbarker commented Mar 23, 2024

Tested using an Eros pod. The flag works as expected similar result to that seen in loopandlearn/OmniBLE#5 (comment).

@marionbarker marionbarker merged commit 0174b22 into silent_pod_and_diagnostics Mar 23, 2024
@marionbarker
Copy link
Author

marionbarker commented Mar 23, 2024

  • For Mac build - paste in terminal in LoopWorkspace folder
  • For Browser build - paste at the beginning of customization section of build_loop.yml
    • If testing more than one module, the update-index commands can be added one after the other
    • The git submodule update must come last

This is the update-index command required to use the silent_pod_and_diagnostics branch after this PR was merged.

git update-index --cacheinfo 160000 0174b224b35c0fc2370a3c3fe7217faea73360ad "OmniKit"
git submodule update

Then build.

For the iphone version of iAPS that uses submodules - the Silence Pod and Pod diagnostics should be present because in the OmniKit Pod Settings screen because the logic flag is hard-coded to true.

For Loop, when DEBUG_FEATURES_ENABLED is commented out of the LoopConfigOverride.xcconfig file, the extra features are not present, when that flag is present (default for DIY Loop), the extra features are present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant