Skip to content

[test]fix: return enum from discovery #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aaqilniz wants to merge 1 commit into from
Closed

[test]fix: return enum from discovery #543

aaqilniz wants to merge 1 commit into from

Conversation

@aaqilniz
Copy link
Contributor

@aaqilniz aaqilniz commented Nov 15, 2023

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@aaqilniz
fix: return enum from discovery
5c91965 
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
@aaqilniz aaqilniz mentioned this pull request Nov 15, 2023
Merged
5 tasks
@aaqilniz aaqilniz closed this Nov 16, 2023
@aaqilniz aaqilniz changed the title fix: return enum from discovery [test]fix: return enum from discovery Nov 16, 2023
@aaqilniz aaqilniz deleted the fix/handle-enum-type branch November 22, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhmlau dhmlau Awaiting requested review from dhmlau dhmlau will be requested when the pull request is marked ready for review dhmlau is a code owner

@marioestradarosa marioestradarosa Awaiting requested review from marioestradarosa marioestradarosa will be requested when the pull request is marked ready for review marioestradarosa is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aaqilniz