fixup! apply feedback

loopbackio · Feb 20, 2019 · a9d4a3f · a9d4a3f
1 parent db39d78
commit a9d4a3f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/lib/connector.js b/lib/connector.js
@@ -158,7 +158,7 @@ Connector.getNestedPropertyDefinition = function(definition, propPath) {
   if (propPath.length === 1) return prop;
 
   if (isPropUndefined || (propPath.length > 1 && (isArray && prop.type.length === 0))) {
-    throw new Error(g.f('Invalid property path'));
+    return undefined;
   }
 
   const nextDefinition =

diff --git a/test/connector.test.js b/test/connector.test.js
@@ -96,12 +96,11 @@ describe('Connector', () => {
       expect(propDefinition.type).to.equal(Date);
     });
 
-    it('should fail for non-existing properties', () => {
-      expect(() =>
-        connector.getPropertyDefinition(
-          'MyModel',
-          'non.existing.property'
-        )).to.throw(/Invalid property path/);
+    it('should return undefined for non-existing properties', () => {
+      const definition = connector.getPropertyDefinition('MyModel',
+        'non.existing.property');
+      // eslint-disable-next-line no-unused-expressions
+      expect(definition).to.be.undefined;
     });
 
     it('should preserve backward-compatibility for non-existing property', () => {