Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support array within array in 3.x #1701

Merged
merged 1 commit into from
Mar 19, 2019
Merged

feat: support array within array in 3.x #1701

merged 1 commit into from
Mar 19, 2019

Conversation

hacksparrow
Copy link
Contributor

Description

POST request body:

 { items": [
    [
      {"name": "APPLE"},
      {"serial": 67}
    ]
  ]
}

Currently stored as:

 { "items": [
    {
      "0": {
        "name": "APPLE"
      },
      "1": {
        "serial": 67
      }
    }
  ]
}

Will be stored as:

 { items": [
    [
      {
        "name": "APPLE"
      },
      {
        "serial": 67
      }
    ]
  ]}

Related issues

strongloop/loopback#4132

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@bajtos
Copy link
Member

bajtos commented Mar 14, 2019

Is this a back-port of #1699? Was the back-port trivial, or did you have to make any significant changes?

Let's wait until the first pull request against master is landed and then proceed with reviewing backports.

@hacksparrow
Copy link
Contributor Author

Is this a back-port of #1699? Was the back-port trivial, or did you have to make any significant changes?

Trivial.

However, it is not so for 2.x. Still working on it.

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a back-port of #1699? Was the back-port trivial, or did you have to make any significant changes?

Trivial.

👍

@hacksparrow hacksparrow merged commit 2f093ce into 3.x Mar 19, 2019
@bajtos bajtos deleted the 3x/list-format branch March 19, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants