Skip to content

Commit

Permalink
fix(build): remove "dom" from the list of global libraries
Browse files Browse the repository at this point in the history
Historically, we were including "dom" because it was required by
supertest's type declarations to pass the compilation. Now that we are
not type-checking declaration files, we don't need "dom" library any
more.

Please note that "dom" library is for HTML/Browser environment only,
no Node.js code should be depending on DOM types, e.g. the global
`Request` object provided by browsers.
  • Loading branch information
bajtos committed Mar 21, 2019
1 parent 66bb506 commit 781cd1d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/build/config/tsconfig.common.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"strictBindCallApply": true,
"skipLibCheck": true,

"lib": ["es2018", "dom", "esnext.asynciterable"],
"lib": ["es2018", "esnext.asynciterable"],
"module": "commonjs",
"moduleResolution": "node",
"target": "es2017",
Expand Down
3 changes: 2 additions & 1 deletion packages/cli/generators/project/templates/tsconfig.json.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@
"noImplicitAny": true,
"strictNullChecks": true,
"resolveJsonModule": true,
"skipLibCheck": true,
"lib": ["es2018", "dom", "esnext.asynciterable"],
"lib": ["es2018", "esnext.asynciterable"],
"module": "commonjs",
"moduleResolution": "node",
"target": "es2017",
Expand Down

0 comments on commit 781cd1d

Please sign in to comment.