chore: make the code compatible with node 10.0.0 #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace new Buffer() with Buffer.from() - Work around nodejs/node#20278 - Upgrade to source-map-support@0.5.5
virkt25
reviewed
Apr 25, 2018
| if (isClass(cls)) { | ||
| classes.push(cls); | ||
| const moduleObj = require(file); | ||
| // WORKAROUND: use `for in` instead of Object.values(). |
There was a problem hiding this comment.
Once the issue is fixed, I don't think we need to change this back ... it works the same so I would propose removing the comment.
There was a problem hiding this comment.
The purpose of the comment is recording keeping. When developers blame the git history, they will know why the change is made.
virkt25
approved these changes
Apr 25, 2018
b-admike
approved these changes
Apr 25, 2018
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated