Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openapi-v3): set required to true for path parameters #1633

Merged
merged 1 commit into from
Aug 21, 2018
Merged

fix(openapi-v3): set required to true for path parameters #1633

merged 1 commit into from
Aug 21, 2018

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Aug 21, 2018 •
edited
Loading

#1531

It sets required: true for path parameters to be compliant with OpenAPI spec.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@raymondfeng raymondfeng requested a review from bajtos as a code owner August 21, 2018 20:35
@raymondfeng raymondfeng force-pushed the set-required-for-path-parm branch from 0c93cf0 to cc2b34c Compare August 21, 2018 20:35
virkt25
virkt25 approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@virkt25 virkt25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

jannyHou
jannyHou approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃 :shipit:

@raymondfeng raymondfeng merged commit 2b13247 into master Aug 21, 2018
@raymondfeng raymondfeng deleted the set-required-for-path-parm branch August 21, 2018 21:00
@bajtos bajtos mentioned this pull request Aug 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virkt25 virkt25 virkt25 approved these changes

@jannyHou jannyHou jannyHou approved these changes

@b-admike b-admike b-admike approved these changes

@bajtos bajtos Awaiting requested review from bajtos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raymondfeng @virkt25 @jannyHou @b-admike