Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): add config option to disable API Explorer redirects #2016

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Nov 12, 2018

To allow users to mount self-hosted API Explorer at /explorer, we need to allow them to disable the redirect pointing /explorer to the externally hosted swagger-ui instance.

In this pull request, I am modifying the REST component to allow the config option rest.apiExplorer to be configured to false, thus disabling redirects.

See also #1664, #1976, #1960 and #559.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • n/a API Documentation in code was updated
  • Documentation in /docs/site was updated
  • n/a Affected artifact templates in packages/cli were updated
  • n/a Affected example projects in examples/* were updated

@bajtos bajtos self-assigned this Nov 13, 2018
@bajtos bajtos force-pushed the feat/disable-swagger-redirect branch from cef166c to 96fe6a1 Compare November 13, 2018 07:10
@bajtos bajtos merged commit b4d9bc5 into master Nov 13, 2018
@bajtos bajtos deleted the feat/disable-swagger-redirect branch November 13, 2018 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants