Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: explain request handling phases and Express middleware #2671

Merged
merged 1 commit into from
Apr 5, 2019
Merged

docs: explain request handling phases and Express middleware #2671

merged 1 commit into from
Apr 5, 2019

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Apr 2, 2019

Resolves #2390:

Describe request handling steps. Explain the order in which different middleware and route handlers are invoked in LB4, what extension points are provided.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@bajtos bajtos added the Docs label Apr 2, 2019
@bajtos bajtos added this to the April 2019 milestone milestone Apr 2, 2019
@bajtos bajtos self-assigned this Apr 2, 2019
nabdelgadir
nabdelgadir approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@nabdelgadir nabdelgadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

raymondfeng
raymondfeng reviewed Apr 2, 2019
View reviewed changes
docs/site/Sequence.md Outdated Show resolved Hide resolved
jannyHou
jannyHou approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@bajtos bajtos force-pushed the docs/request-handling-phases branch from 43a47ee to ab7fc40 Compare April 5, 2019 07:10
@bajtos bajtos merged commit f2c2264 into master Apr 5, 2019
@bajtos bajtos deleted the docs/request-handling-phases branch April 5, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannyHou jannyHou jannyHou approved these changes

@raymondfeng raymondfeng raymondfeng left review comments

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@emonddr emonddr Awaiting requested review from emonddr

@b-admike b-admike Awaiting requested review from b-admike

@dhmlau dhmlau Awaiting requested review from dhmlau

Assignees

@bajtos bajtos

Labels
Docs
Projects
None yet
Milestone
April 2019 milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bajtos @raymondfeng @jannyHou @nabdelgadir