Custom foreign key name #3326
Merged
Custom foreign key name #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabdelgadir
commented
Jul 9, 2019
| @@ -29,7 +29,7 @@ export class AddressRepository extends DefaultCrudRepository< | |||
| customerRepositoryGetter: Getter<CustomerRepository>, | |||
| ) { | |||
| super(Address, db); | |||
| this.customer = this._createBelongsToAccessorFor( | |||
| this.customer = this.createBelongsToAccessorFor( | |||
There was a problem hiding this comment.
Because of this change, there's no longer coverage for _createBelongsToAccesorFor: https://coveralls.io/builds/24455533/source?filename=packages/repository/src/repositories/legacy-juggler-bridge.ts#L259. Should I revert it?
There was a problem hiding this comment.
It's deprecated, so not sure what the best course of action should be. For now, we could duplicate the tests for coverage of both until we remove it. @bajtos thoughts?
There was a problem hiding this comment.
I reverted it so the function is still covered, but I can open another PR if we want to change it to the non-deprecated version.
b-admike
approved these changes
Jul 11, 2019
raymondfeng
approved these changes
Jul 12, 2019
nabdelgadir
force-pushed
the
custom-relation-keys
branch
from
c843223 to
89acaed
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2169.
keyToactually exists in the target model{ModelName}Idwork e.g. with underscores or a completely different name) for the foreign key also work.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈