Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add keynote source file for diagrams #3586

Merged
merged 1 commit into from
Aug 20, 2019
Merged

chore: add keynote source file for diagrams #3586

merged 1 commit into from
Aug 20, 2019

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Aug 20, 2019

As @raymondfeng suggested, I'm putting the keynote file that contains the diagrams, so that we have the "source" to edit/add diagrams we used in documentation.

It includes the diagrams created in PR #3462.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@raymondfeng
Copy link
Contributor

Maybe keep it in a different directory, such as diagrams?

@dhmlau
Copy link
Member Author

dhmlau commented Aug 20, 2019

Done. Moving to docs/site/diagrams/ folder.

@raymondfeng
Copy link
Contributor

Maybe move it to docs/diagrams and add diagrams to .npmignore so that it won't be published to npm?

@dhmlau dhmlau self-assigned this Aug 20, 2019
@dhmlau dhmlau merged commit dea52c7 into master Aug 20, 2019
@dhmlau dhmlau deleted the image-src branch August 20, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants