Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update frpc to use latest frisbee polyglot etc apis #41

Merged
merged 10 commits into from
Apr 25, 2024
Merged

refactor: Update frpc to use latest frisbee polyglot etc apis #41

merged 10 commits into from
Apr 25, 2024

Conversation

SuperManifolds
Copy link
Contributor

Description

Updated fRPC's Polyglot and Frisbee dependencies to the latest versions and updated generated code to conform to changes in Polyglot API

Fixes FRPC-6

Type of change

  • Refactor (non-breaking code changes that do not add new functionality or break existing functionality) [title: 'refactor:']

Testing

Please make sure that existing test cases pass (with go test ./... -race and go test -bench=. ./... -race),
and if required please add new test cases and list them below:

Final Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@SuperManifolds SuperManifolds self-assigned this Apr 4, 2024
@SuperManifolds SuperManifolds force-pushed the alex/frpc-6-update-frpc-to-use-latest-frisbee-polyglot-etc-apis branch 2 times, most recently from d7085fe to e92b32c Compare April 4, 2024 19:58
@SuperManifolds SuperManifolds marked this pull request as draft April 9, 2024 17:03
@SuperManifolds SuperManifolds mentioned this pull request Apr 16, 2024
Closed
@SuperManifolds SuperManifolds marked this pull request as ready for review April 23, 2024 19:36
@SuperManifolds
Update dependencies
c815357 
Signed-off-by: Alex Sørlie Glomsaas <alex@sorlie.io>
@SuperManifolds
Remove debug statement
a30b884 
Signed-off-by: Alex Sørlie Glomsaas <alex@sorlie.io>
@SuperManifolds
Updated fRPC to use latest Polyglot and Frisbee versions
76de98f 
* Upadted dependency versions
* Updated generated code to conform to API changes

Signed-off-by: Alex Sørlie Glomsaas <alex@sorlie.io>
@SuperManifolds
Fix potential newlines in version file breaking code generation
622ecea 
Signed-off-by: Alex Sørlie Glomsaas <alex@sorlie.io>
@SuperManifolds
Bump required go version to 1.20
6c41de9 
Signed-off-by: Alex Sørlie Glomsaas <alex@sorlie.io>
@SuperManifolds
Ensure required go version is passed as string because yaml is dumb
385acd5 
Signed-off-by: Alex Sørlie Glomsaas <alex@sorlie.io>
@SuperManifolds
Update polyglot dependency for v2 structure
35308d9 
Signed-off-by: Alex Sørlie Glomsaas <alex@sorlie.io>
@SuperManifolds
Tidy go mods
898259e 
Signed-off-by: Alex Sørlie Glomsaas <alex@sorlie.io>
@SuperManifolds
Fix go version in workflows
ae71d53 
Signed-off-by: Alex Sørlie Glomsaas <alex@sorlie.io>
@SuperManifolds SuperManifolds force-pushed the alex/frpc-6-update-frpc-to-use-latest-frisbee-polyglot-etc-apis branch from e9df68b to ae71d53 Compare April 24, 2024 16:28
ShivanshVij
ShivanshVij previously approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@ShivanshVij ShivanshVij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperManifolds SuperManifolds merged commit 0797eea into staging Apr 25, 2024
3 of 4 checks passed
@SuperManifolds SuperManifolds deleted the alex/frpc-6-update-frpc-to-use-latest-frisbee-polyglot-etc-apis branch April 25, 2024 18:03
This was referenced Apr 25, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShivanshVij ShivanshVij ShivanshVij left review comments

Assignees

@SuperManifolds SuperManifolds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperManifolds @ShivanshVij