Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger: add With() method to persist log labels #5

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jul 29, 2024

Add With() method to loggers to create a sublogger with a set of persistent labels that can be used to generate consistent log messages for a given resource.

Add `With()` method to loggers to create a sublogger with a set of
persistent labels that can be used to generate consistent log messages
for a given resource.
@lgfa29 lgfa29 requested review from ShivanshVij and pojntfx July 29, 2024 17:22
Copy link
Member

@ShivanshVij ShivanshVij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just needs some changes to interfaces

types/types.go Show resolved Hide resolved
Copy link
Member

@ShivanshVij ShivanshVij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShivanshVij ShivanshVij enabled auto-merge (squash) July 30, 2024 01:48
@ShivanshVij ShivanshVij merged commit ba1e898 into main Jul 30, 2024
2 checks passed
@ShivanshVij ShivanshVij deleted the f-logger-with branch July 30, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants