Add support to install framework using pip and user defined version and refactor bootstrap and env clean #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sathnaga
force-pushed
the
add_branch_support
branch
from
fee1239 to
c2b15fb
Compare
|
Test: |
|
This pull request fixes 1 alert when merging c2b15fb into 6dbe17a - view on LGTM.com fixed alerts:
|
sathnaga
changed the title
|
Moving to different version of framework becomes easier and reliable now : Kvm test dry run did not work due to a known issue with 80.0 version as expected. |
harish-24
reviewed
Sep 8, 2020
sathnaga
force-pushed
the
add_branch_support
branch
from
c2b15fb to
98200dd
Compare
|
This pull request fixes 1 alert when merging 98200dd into 84150d0 - view on LGTM.com fixed alerts:
|
Lately, we are noticing lot of issues due to broken framework in the environment using the unmatching version across different plugins, so let's avoid the direct repo install and use standard pip installation for framework and its plugin, by default it will install the latest released version of framework if bootstrapped, having said that user could choose the different version than default as needed through config and use the git repo aswell, details of how to choose different config options are documented in the config file comment section. Refactored the bootstrap workflow and env clean to have the proper environment to start with and clean the environment properly when asked, earlier unwanted steps were run. miscellaneous pylint fixes. Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
sathnaga
force-pushed
the
add_branch_support
branch
from
98200dd to
a44babd
Compare
|
This pull request fixes 1 alert when merging a44babd into 84150d0 - view on LGTM.com fixed alerts:
|
harish-24
approved these changes
Sep 14, 2020
|
@narasimhan-v seeing you have self requested review, do you have any comments?, it is good to have this merged soon, Thanks! |
|
@sathnaga I am yet to test the script. Will complete review by EOD. |
There was a problem hiding this comment.
@sathnaga Code looks good, but is it possible to split it into separate commits ? One for pip install, one for bootstrap refactor, etc ?
It's little interlinked in current state, I doubt I will have enough time to break it. probably will keep in mind for future change.. |
narasimhan-v
approved these changes
Sep 22, 2020
|
Sure. Are we waiting for anymore reviews ? Or can this be merged ? |
|
@narasimhan-v I guess we have two approvals, we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lately, we are noticing lot of issues due to broken framework
in the environment using the unmatching version across different
plugins, so let's avoid the direct repo install and use standard
pip installation for framework and its plugin, by default it will
install the latest released version of framework if bootstrapped,
having said that user could choose the different version than
default as needed through config and use the git repo aswell,
details of how to choose different config options are documented
in the config file comment section.
Refactored the bootstrap workflow and env clean to have the
proper environment to start with and clean the environment properly
when asked, earlier unwanted steps were run.
miscellaneous pylint fixes.
Signed-off-by: Satheesh Rajendran sathnaga@linux.vnet.ibm.com