Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Блоки: Освещение: add candles_3d mod as submodule #1088

Closed
alek13 opened this issue Jul 19, 2023 · 2 comments
Closed

Блоки: Освещение: add candles_3d mod as submodule #1088

alek13 opened this issue Jul 19, 2023 · 2 comments
Milestone
2023.07

Comments

@alek13
Copy link
Member

alek13 commented Jul 19, 2023

Note:

Just adding not works, only orange candles.
Needs PR with fix into origin.
Our fork: https://gitlab.com/lord-server/candles_3d
@alek13 alek13 converted this from a draft issue Jul 19, 2023
@alek13
Copy link
Member Author

alek13 commented Jul 21, 2023

PR with fix: https://gitlab.com/mazes_80/candles_3d/-/merge_requests/1

@alek13 alek13 closed this as completed in 59e38fc Aug 1, 2023
@alek13
Copy link
Member Author

alek13 commented Aug 1, 2023

Different vision whether crafts are needed for colored candles.
So I decide to maintain our fork. And add as submodule exactly the fork instead upstream.

alek13 added a commit to alek13/lord that referenced this issue Aug 1, 2023
@alek13
Add our fork candles_3d as submodule. Closes lord-server#1088
a198273
alek13 added a commit to alek13/lord that referenced this issue Aug 1, 2023
@alek13
Add our fork candles_3d as submodule. Closes lord-server#1088
d124886
@alek13 alek13 added this to the 2023.07 milestone Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Блоки (базовые)
Status: Done
Milestone
2023.07
Development

No branches or pull requests
1 participant
@alek13