Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clans v2: nickname changes: use player_nametag mod #1423

Closed
4 tasks done
alek13 opened this issue Jun 4, 2024 · 0 comments
Closed
4 tasks done

Clans v2: nickname changes: use player_nametag mod #1423

alek13 opened this issue Jun 4, 2024 · 0 comments
Assignees
@alek13

Comments

@alek13
Copy link
Member

alek13 commented Jun 4, 2024 •
edited
Loading

В нескольких модах используется изменение nametg игрока (напр, в Player/show_health).
Нужен общий для всех модоов менеджер:
blocked by:

todo:

  • use player_nametag
  • move into separate file
  • unify usage
  • subscribe & use own callbacks
@alek13 alek13 added this to Clans Jun 4, 2024
@alek13 alek13 converted this from a draft issue Jun 4, 2024
@alek13 alek13 moved this to Todo in Clans Jun 4, 2024
@alek13 alek13 mentioned this issue Jun 4, 2024
Open
@alek13 alek13 added this to Player Jun 5, 2024
@alek13 alek13 moved this to Todo in Player Jun 5, 2024
@alek13 alek13 removed this from Player Jun 5, 2024
@alek13 alek13 changed the title Clans v2: extract player nickname into separate mod Clans v2: move nickname changes to player_nametag mod Jun 5, 2024
@alek13 alek13 changed the title Clans v2: move nickname changes to player_nametag mod Clans v2: nickname changes: use player_nametag mod Jun 6, 2024
alek13 added a commit to alek13/lord that referenced this issue Jun 6, 2024
@alek13
Clans v2: use player_nametag mod. Relates to lord-server#1423
6dce756
alek13 added a commit to alek13/lord that referenced this issue Jun 6, 2024
@alek13
Clans v2: change callbacks signature; use own callbacks for nametags.…
d5c976f 
… Relates to lord-server#1423
alek13 added a commit to alek13/lord that referenced this issue Jun 6, 2024
@alek13
Clans v2: unify change player nametsg; remove redundant functions. Re…
5ee55ac 
…lates to lord-server#1423
@alek13 alek13 closed this as completed in 6dc6e3f Jun 6, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Clans Jun 6, 2024
alek13 added a commit to alek13/lord that referenced this issue Jun 6, 2024
@alek13
Clans v2: fix fogotten require("clans.players.nametag"). Relates to l…
a7a930f 
…ord-server#1423.
@alek13 alek13 self-assigned this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alek13 alek13

Labels
None yet
Projects
Clans
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alek13