Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lord/lottarmor: цикломатическая сложность #732

Closed
ssdaniel24 opened this issue Aug 25, 2022 · 0 comments
Closed

lord/lottarmor: цикломатическая сложность #732

ssdaniel24 opened this issue Aug 25, 2022 · 0 comments
Assignees
@alek13
Labels
cyclomatic Связанное с цикломатической сложностью refactoring Касающееся крупной переработки имеющейся возможности

Comments

@ssdaniel24
Copy link
Contributor 

Checking mods/lord/lottarmor/armor.lua            10 warnings

    ...
    mods/lord/lottarmor/armor.lua:181:26: cyclomatic complexity of function armor.set_player_armor is too high (26 > 10)
    mods/lord/lottarmor/armor.lua:279:22: cyclomatic complexity of function armor.update_armor is too high (21 > 10)
    ...
    mods/lord/lottarmor/armor.lua:451:15: cyclomatic complexity of function is too high (11 > 10)
    ...

Checking mods/lord/lottarmor/init.lua             OK
Checking mods/lord/lottarmor/multiskin.lua        3 warnings

    ...

Checking mods/lord/lottarmor/shield.lua           OK
Checking mods/lord/lottarmor/transform.lua        OK
Checking mods/lord/lottarmor/wieldview.lua        OK
@ssdaniel24 ssdaniel24 added refactoring Касающееся крупной переработки имеющейся возможности cyclomatic Связанное с цикломатической сложностью labels Aug 25, 2022
alek13 added a commit to alek13/lord that referenced this issue Feb 9, 2023
@alek13
Extract inventory form into separate files. Closes lord-server#976
6e9f350 
  also decrease cyclomatic comlexity in detached armor inv. Relates to lord-server#732
@alek13 alek13 moved this from Todo to In Progress in Рефакторинг May 26, 2023
alek13 added a commit to alek13/lord that referenced this issue May 26, 2023
@alek13
Refactoring lottarmor: extract collect_physics(). Relates to lord…
ae14023 
…-server#732, lord-server#339, lord-server#1012
alek13 added a commit to alek13/lord that referenced this issue May 26, 2023
@alek13
Refactoring lottarmor: extract rebuild_armor_groups(). Relates to l…
3885455 
…ord-server#732, lord-server#339, lord-server#1012
@alek13 alek13 added this to the 2023.04 milestone May 27, 2023
@alek13 alek13 self-assigned this May 27, 2023
@alek13 alek13 closed this as completed in 8c8e551 May 27, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Рефакторинг May 27, 2023
@Doloment Doloment removed this from the 2023.05 milestone Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alek13 alek13

Labels
cyclomatic Связанное с цикломатической сложностью refactoring Касающееся крупной переработки имеющейся возможности
Projects
Рефакторинг
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alek13 @Doloment @ssdaniel24