Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing salt to salt_block as product of salt bucket #1794

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

lord-sakamoto
Copy link
Contributor

Описание PR:

Makes a salt bucket produce a salt block instead of a single salt. This solves half of the salt creation problem.

Рекомендации к тесту:

Still trying to figure out GIT, so take all this with a grain of salt.

Дополнительная информация:

Related: #1792

@ssdaniel24 ssdaniel24 requested a review from alek13 November 18, 2024 14:00
@alek13
Copy link
Member

alek13 commented Nov 18, 2024

yep, but you forgot to add the changes from the second point.
we can already merge this, if you want, and just mark the first point as done.
or you want to try to add changes with bottle ?

@lord-sakamoto
Copy link
Contributor Author

yep, but you forgot to add the changes from the second point. we can already merge this, if you want, and just mark the first point as done. or you want to try to add changes with bottle ?

I'll try to do the water bottle part today, although I'm not completely sure which file should I modify for that. I'm okay with this being merged separately though.

@alek13 alek13 merged commit bc11b7e into lord-server:dev Nov 19, 2024
1 check passed
@alek13 alek13 mentioned this pull request Nov 19, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants