Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Сохранение расы, пола и скина в базе #466

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Сохранение расы, пола и скина в базе #466

wants to merge 3 commits into from

Conversation

vladtcvs
Copy link
Contributor

Для хранения расы, пола и скина используется метаданные игрока, созраняемые в базе.

Также в lottpotions и hbhunger были вставлены проверки, чтобы не падали

@vladtcvs vladtcvs force-pushed the player-db branch 3 times, most recently from e3627f9 to c8d590a Compare October 31, 2021 10:51
@Doloment Doloment added the feature Введение новой возможности label Nov 4, 2021
@alek13
Copy link
Member

alek13 commented Nov 4, 2021

договорились разнести:

  • правки багов в _lott/lottpotion в отдельный PR
  • правки багов в _various/hud_modpack/hbhunger в отдельный PR
  • сохранение в базу в отдельный PR

@alek13 alek13 self-requested a review November 4, 2021 19:17
@alek13 alek13 added the waiting on author Для PR: ожидание создателя PR label Nov 4, 2021
@vladtcvs vladtcvs mentioned this pull request Nov 4, 2021
Open
@alek13 alek13 removed the waiting on author Для PR: ожидание создателя PR label Dec 19, 2021
@alek13 alek13 requested a review from weqqr December 19, 2021 22:08
@vladtcvs vladtcvs added the needs review Для PR: необходимо рассмотрение label Jan 9, 2022
@weqqr weqqr changed the base branch from master to dev March 7, 2022 13:42
@Doloment Doloment added enhancement Улучшение имеющейся возможности and removed feature Введение новой возможности labels May 3, 2022
alek13
alek13 requested changes Dec 16, 2022
View reviewed changes
Copy link
Member

@alek13 alek13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вцелом, LGTM. Нужна только небольшая правка по неймингу

mods/lord/lord_classes/init.lua Outdated Show resolved Hide resolved
mods/lord/lord_classes/init.lua Outdated
Comment on lines 218 to 198
local gender = pmeta:get_string("classes:gender")
if gender == nil or gender == "" then
if table_contains(cache.players, name) then
-- legacy compatibility
gender = cache.players[name][2]
else
gender = races.default[2]
end
pmeta:set_string("classes:gender", gender)
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

уж очень похожие 2 куска кода.
напрашивается вынесение в функцию, но можно вынести в отдельную задачу в проект рефакторинга, тем более, что он тут уже давно напрашивается полностью.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Куски короткие и очень понятные, можно и так оставить, не критично

weqqr
weqqr reviewed Dec 16, 2022
View reviewed changes
Copy link
Contributor

@weqqr weqqr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Совместимость со старым форматом мешает читаемости, может лучше сделать скрипт для переноса существующих данных и убрать легаси код?

mods/lord/lord_classes/init.lua Outdated
local player = minetest.get_player_by_name(name)
local pmeta = player:get_meta()

local race = pmeta:get_string("classes:race")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Как насчёт окончательно переименовать classes в races (и мод в том числе)?

mods/lord/lord_classes/init.lua Outdated Show resolved Hide resolved
mods/lord/lord_classes/init.lua Outdated
Comment on lines 218 to 198
local gender = pmeta:get_string("classes:gender")
if gender == nil or gender == "" then
if table_contains(cache.players, name) then
-- legacy compatibility
gender = cache.players[name][2]
else
gender = races.default[2]
end
pmeta:set_string("classes:gender", gender)
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Куски короткие и очень понятные, можно и так оставить, не критично

@vladtcvs vladtcvs force-pushed the player-db branch 3 times, most recently from ba6271e to d71de60 Compare December 27, 2022 15:02
alek13
alek13 reviewed Dec 28, 2022
View reviewed changes
mods/lord/lord_classes/init.lua Outdated
pmeta:set_string("player:race", race_and_gender[1])
pmeta:set_string("player:gender", race_and_gender[2])

-- races.update_player(name, race_and_gender, races.default_skin)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

забыл удалить закомментированный код

alek13 added a commit to vladtcvs/lord that referenced this pull request Dec 29, 2022
@alek13
lord-server#466 lord-server#472 transfer_races.lua refactor & fix f…
f986902 
…ield name
alek13 added a commit to vladtcvs/lord that referenced this pull request Dec 29, 2022
@alek13
lord-server#466 lord-server#472 transfer_races.lua refactor & fix f…
62fd6a5 
…ield name
alek13 added a commit to vladtcvs/lord that referenced this pull request Dec 29, 2022
@alek13
lord-server#466 lord-server#472 transfer_races.lua refactor & fix f…
466c099 
…ield name
alek13 added a commit to vladtcvs/lord that referenced this pull request Dec 29, 2022
@alek13
lord-server#466 lord-server#472 transfer_races.lua refactor & fix f…
988df4a 
…ield name
@alek13 alek13 added this to the next-milestone milestone Dec 29, 2022
@Doloment Doloment modified the milestones: 2023.05, next-milestone Jun 8, 2023
@alek13 alek13 modified the milestones: next-milestone, 2023.06 Jul 5, 2023
@alek13 alek13 modified the milestones: 2023.06, next-milestone Jul 15, 2023
@alek13 alek13 removed this from the next-milestone milestone Aug 14, 2023
@alek13 alek13 added the refactoring Касающееся крупной переработки имеющейся возможности label Sep 27, 2023
@alek13 alek13 mentioned this pull request Sep 27, 2023
Closed
3 tasks
vladtcvs and others added 3 commits October 20, 2023 14:01
@vladtcvs @alek13
Fix lord-server#472: get rid of races.txt
af82f51 
* Use player meta for storing race, skin, gender, race privs, second chance
* Add converter script races.txt -> races.sql
@alek13
add shebang & +x for util/transfer.lua
69e6499
@alek13
lord-server#466 lord-server#472 transfer_races.lua refactor & fix f…
5339f1a 
…ield name
@alek13
Copy link
Member

alek13 commented May 21, 2024

@vladtcvs , сможешь посмотреть что тут было ?

@alek13
Copy link
Member

alek13 commented May 21, 2024

@vladtcvs , возможно многое поменялось, надо бы вспомнить что тут.
Создал ветку в Дискорд: https://discord.com/channels/268093825975713793/1242440032711606323

@alek13 alek13 marked this pull request as draft December 23, 2024 18:57
@alek13
Copy link
Member

alek13 commented Dec 23, 2024

PR устареыший, требует кучу доработок, но нам нужны скрипты из него.
Поэтому пока оставляю висеть как напоминалка. И перевожу в черновик.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weqqr weqqr weqqr left review comments

@alek13 alek13 alek13 requested changes

Assignees

@vladtcvs vladtcvs

Labels
enhancement Улучшение имеющейся возможности needs review Для PR: необходимо рассмотрение refactoring Касающееся крупной переработки имеющейся возможности
Projects
Рефакторинг
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vladtcvs @alek13 @weqqr @Doloment