Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rmarkdown files to parsable-R hook #325

Merged
merged 9 commits into from
Nov 30, 2021

Conversation

pwildenhain
Copy link
Contributor

Closes #319

@lorenzwalthert
Copy link
Owner

lorenzwalthert commented Nov 30, 2021

Looks great overall, I adjusted the docs for the vignette on available hooks and pushed one cosmetic change (use tempfile() directly). Also, you added your test to test/testthat/test-all.R. This file was renamed to test-hooks.R and should not be around (but was recovered in some git operation). I'll delete it in a separate PR, but can you add your tests to tests/testthat/test-hooks.R instead? I you don't want or it's too complicated, I can do it.

@pwildenhain
Copy link
Contributor Author

Also, you added your test to test/testthat/test-all.R.

It's funny, I originally did add this to test-hooks.R but when I went back and read the CONTRIBUTING.md I added it to test-all.R 😂

I'll make that change, and then make a few updates to CONTRIBUTING.md in a separate PR

@lorenzwalthert
Copy link
Owner

Also, all errors you see are unrelated.

@pwildenhain
Copy link
Contributor Author

The CONTRIBUTING.md also mentions needing to add the hook script to the inst/bin directory -- is this still the case? I only made changes to inst/hooks

@lorenzwalthert
Copy link
Owner

lorenzwalthert commented Nov 30, 2021

That directory was renamed to inst/hooks/exported, so please use this path.

@lorenzwalthert lorenzwalthert merged commit 78ea6e8 into lorenzwalthert:main Nov 30, 2021
@lorenzwalthert
Copy link
Owner

Thanks again @pwildenhain 🥳

@pwildenhain pwildenhain deleted the add-parsable-rmd branch December 2, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hook for parseable Rmd
2 participants