Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headers affects common_headers #284

Closed
valfa14 opened this issue Oct 25, 2017 · 4 comments
Closed

headers affects common_headers #284

valfa14 opened this issue Oct 25, 2017 · 4 comments
Labels
bug

Comments

@valfa14
Copy link
Contributor

valfa14 commented Oct 25, 2017 •
edited
Loading

g = Grab()
assert g.config['common_headers'].keys() == Grab().common_headers().keys()
g.setup(headers={"dd": "dd"})
g.go("localhost:8000")
assert g.config['common_headers'].keys() == Grab().common_headers().keys()
#283
@valfa14 valfa14 mentioned this issue Oct 25, 2017
Closed
@valfa14
Copy link
Contributor Author

valfa14 commented Jan 18, 2018

Someone looked at it? :(

@valfa14
Copy link
Contributor Author

valfa14 commented Jan 31, 2018

@lorien Do you need more info? Or can I help somehow with pushing forward?

@lorien lorien added the bug label Apr 7, 2018
@lorien
Copy link
Owner

lorien commented Apr 13, 2018

Hey @valfa14
Thanks for reporting this bug.
Could you provide code example of this bug affects on correct program workflow?

lorien added a commit that referenced this issue May 3, 2018
@lorien
Write tests for #284 issue: headers affects common_headers
5020cdf
@lorien
Copy link
Owner

lorien commented May 4, 2018

Fixed in #336

@lorien lorien closed this as completed May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avoid to update of common_headers valfa14/grab
2 participants
@lorien @valfa14