Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Document object not references to Grab object #328

Closed
lorien opened this issue May 1, 2018 · 0 comments
Closed

Make Document object not references to Grab object #328

lorien opened this issue May 1, 2018 · 0 comments
Labels
enhancement

Comments

@lorien
Copy link
Owner

lorien commented May 1, 2018

For Document:

  • Remove self.grab link
    • Actually, do not remove it yet because of backward compatibility, grab.doc.submit() should still works but generates warning.
  • Store standalone copy of required (all?) grab.config settings
  • Move submit() method from Document to Grab

That would solve #67
@lorien lorien closed this as completed in 3c6d2e1 May 2, 2018
lorien added a commit that referenced this issue May 2, 2018
@lorien
Merge pull request #329 from lorien/issue_328_grab_document
550ea55 
Fix #328, fix #67: remove hard link between document and grab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lorien