Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Laravel 11 #273

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Support Laravel 11 #273

merged 8 commits into from
Mar 13, 2024

Conversation

patrickomeara
Copy link
Contributor

Only support two latest major versions of Laravel as per Support Policy https://laravel.com/docs/11.x/releases#support-policy

Remove Laravel 9 and PHP 8.0 support

Only support two latest major versions of Laravel as per Support Policy https://laravel.com/docs/11.x/releases#support-policy

Remove Laravel 9 and PHP 8.0 support
This commit can be removed and the correct version of lody use after lorisleiva/lody#6 has been merged
@jameswagoner
Copy link

This PR looks proper compared to what Laravel Shift attempted

https://github.com/laravel-shift/laravel-actions/blob/l11-compatibility/composer.json#L25

@nickfls nickfls mentioned this pull request Mar 12, 2024
@nickfls
Copy link
Contributor

nickfls commented Mar 12, 2024

@patrickomeara would you consider adjusting composer.json with

 "phpunit/phpunit": "^9.6 || ^10.0"

@patrickomeara
Copy link
Contributor Author

Good idea @nickfls I have allowed latest versions of Pest and PHPUnit. I leave it up to @lorisleiva to decide whether to release a new major version and remove the lower constraints.

Copy link
Owner

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for this PR but I'm afraid it's not mergeable because its dependencies need to upgrade first.

The reason Lody is not upgraded yet is because Testbench is still under the -dev tag which makes the Shift PR fail.

I can resolve that manually but I'm afraid I've got very little time for these packages right now.

composer.json Outdated
"lorisleiva/lody": "^0.4"
"php": "^8.1",
"illuminate/contracts": "^10.0 || ^11.0",
"lorisleiva/lody": "dev-l11-compatibility"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lody needs to be upgraded first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lorisleiva

I noted that in the commit message

Use Compatible Lody version

This commit can be removed and the correct version of lody use after https://github.com/lorisleiva/lody/pull/6 has been merged

I'm happy for you to use this branch or close it. Whatever is easier.

Thanks for your work.

@lorisleiva lorisleiva merged commit d5c2ca5 into lorisleiva:main Mar 13, 2024
8 checks passed
@oliverearl
Copy link

oliverearl commented Mar 13, 2024

Apologies that it's off-topic, but just wanted to drop in and sincerely thank everyone for getting this through so quickly! I use this library extensively both at work and on the side and this helps us get an early start on Laravel 11 upgrades. 🥳

@patrickomeara
Copy link
Contributor Author

Thanks for your work on this @lorisleiva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants