Injects route parameters into action authorize #308
+26
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💪 Motivation
Currently, when running the authorize method on an Action, the only variable you can access is the ActionRequest by resolving it from the container via dependency injection. This can sometimes lead to the authorize method becoming messy if we need to access a route-model bound model, as an example, and authorize that a certain action can run based on the state of the particular model.
This example might explain it a bit better:
The ActionRequest can still be resolved via dependency injection, so this isn't a breaking change.
🛠 Changes
authorize
method, when authorizing the incoming request🧪 Testing
tests/AsControllerWithAuthorizeAndRulesTest.php
🧙 Reminders (Author)