Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vgmstream to r1896 #390

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

faxx1080
Copy link

Imports changes from r1896 of vgmstream.

I manually went through each file to find cases where the headers change slightly. I've tested on Zelda, Sonic, Metroid but not too many games.

@kode54
Copy link
Collaborator

kode54 commented Jan 20, 2024

I mean, sure, I could import this, but I won't have anything to produce new builds with.

@faxx1080
Copy link
Author

I'm not sure what you mean by that?

Remove stray team ID
@kode54
Copy link
Collaborator

kode54 commented Jan 21, 2024

Also, why did you do this manually? My regular process would have been to format-patch the upstream repository and apply the patches, modifying the code as necessary where the patches fail.

@faxx1080
Copy link
Author

Ahh, because I was still unfamiliar with the macOS edits to vgmstream; and of the build process. The patches looked old (they had dates of 2018) and being used to repos with lots more aged code, I wasn't sure it would work.

That and I was personally impatient myself and wanted to challenge myself to "fix things myself" so I could get Sonic Superstars HCA files working. Once I did, thought it'd be a good idea to contribute back to upstream.

@kode54
Copy link
Collaborator

kode54 commented Jan 22, 2024

I have updated past the snapshot you updated to, but in a branch. It would be most helpful if you could update the libvgmstream project file to include the new files, and reference the renames contained within the commit. There is also a new directory, src/coding/libs that needs its two files added to the project. I will merge the result once tests complete.

However, I don't have a modern Mac to build for the App Store, so there won't be any binary updates for a few months, at least.

@kode54
Copy link
Collaborator

kode54 commented Jan 24, 2024

By the way, for the future reference, format-patch generation should work from the last merged commit hash, which is on the long form version tag that I include with each update to vgmstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants