Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI fails #3

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Fix CI fails #3

merged 2 commits into from
Nov 1, 2021

Conversation

AlexWayfer
Copy link
Contributor

@AlexWayfer AlexWayfer commented Oct 31, 2021 •
edited
Loading

GitHub Setup Ruby Action doesn't recognize Gemfile groups.

Also generate template via bundled gem_generator version.

Also update it.

@AlexWayfer AlexWayfer force-pushed the fix_ci_fails branch 2 times, most recently from 47fa32c to dc6010f Compare October 31, 2021 21:32
@AlexWayfer AlexWayfer marked this pull request as draft October 31, 2021 21:34
@AlexWayfer AlexWayfer force-pushed the fix_ci_fails branch 2 times, most recently from 83ecf32 to 5962626 Compare November 1, 2021 13:01
@AlexWayfer AlexWayfer marked this pull request as ready for review November 1, 2021 13:02
@AlexWayfer AlexWayfer marked this pull request as draft November 1, 2021 13:02
@AlexWayfer AlexWayfer mentioned this pull request Nov 1, 2021
Merged
@olleolleolle
Copy link
Member

Thanks for the fix!

@AlexWayfer
Fix CI fails
c70437f 
Also generate template via bundled `gem_generator` version.

Also update it.
@AlexWayfer
Suppress git warnings in CI
091af40
@AlexWayfer AlexWayfer marked this pull request as ready for review November 1, 2021 13:31
@AlexWayfer
Copy link
Contributor Author

Phew, now it seems OK and ready.

Was not too obvious what's wrong, but fortunately I had similar experience with another generator and its specs a long time ago.

olleolleolle
olleolleolle approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and passes specs!

@olleolleolle olleolleolle merged commit d57d566 into lostisland:main Nov 1, 2021
@olleolleolle
Copy link
Member

Thanks, @AlexWayfer , for your good recall and diligent fixes!

@AlexWayfer AlexWayfer deleted the fix_ci_fails branch November 1, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWayfer @olleolleolle