Add HTTPS Proxy support (#47)

* Add HTTPS Proxy support net-http version 0.5.0 finally introduced TLS proxy support: ruby/net-http#55 https://github.com/ruby/net-http/releases/tag/v0.5.0 * Add mininum net-http version SSL proxies only supported in net-http 0.5.0 or above
lostisland · Nov 11, 2024 · 724af4d · 724af4d
1 parent 046f0cc
commit 724af4d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/faraday-net_http.gemspec b/faraday-net_http.gemspec
@@ -25,5 +25,5 @@ Gem::Specification.new do |spec|
   spec.files = Dir.glob('lib/**/*') + %w[README.md LICENSE.md]
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'net-http'
+  spec.add_runtime_dependency 'net-http', '>= 0.5.0'
 end
diff --git a/lib/faraday/adapter/net_http.rb b/lib/faraday/adapter/net_http.rb
@@ -53,7 +53,8 @@ def net_http_connection(env)
         if proxy
           Net::HTTP.new(env[:url].hostname, port,
                         proxy[:uri].hostname, proxy[:uri].port,
-                        proxy[:user], proxy[:password])
+                        proxy[:user], proxy[:password],
+                        proxy[:uri].scheme == 'https')
         else
           Net::HTTP.new(env[:url].hostname, port, nil)
         end