Fix HTTPS proxy support #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to add tests which would fail with the previous implementation? |
Ensure proxy settings are set correctly. Currently proxy_use_ssl is not exposed as a public method by net-http, so we need to check the instance variable.
richardmarbach
force-pushed
the
fix_tls_proxy_support
branch
from
7a49464
to
beb6dce
Compare
|
@olleolleolle I've added some specs to check that both the HTTP and HTTPS options are set correctly. The specs also fails with the previous implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I'd like to apologise for the oversight in #47. I miscounted the arguments to the existing
Net::HTTPconstructor, as I had only tested directly with theNet::HTTPobject. I tested this change directly with the adapter, and it's correct now.The
nilargument is a "Proxy Filter". I think it's safe to disable as Faraday doesn't seem to support proxy filters.Sorry again for the oversight