Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore backward-compatibility layer for errors #1030

Merged
merged 5 commits into from
Sep 27, 2019
Merged

Restore backward-compatibility layer for errors #1030

merged 5 commits into from
Sep 27, 2019

Commits on Sep 27, 2019

  1. Restore backward-compatibility layer for errors 

    Faraday has been maintaining a backward-compatibility layer for errors
in the `Faraday::Error::` "namespace". These were removed with v0.16.0,
which caused issues for dependents that use semantic versioning
constraints.

It would be best if these were deprecated with a warning message and
then dropped in v1.0 in order to make sure transitive dependencies do
not break.

See octokit/octokit.rb#1154
    @michaelherold
    michaelherold committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    4925803 View commit details
    Browse the repository at this point in the history

  2. Deprecate the old-style errors 

    This adds a very simple deprecation proxy that outputs when a deprecated
constant is referenced. It's based on `ActiveSupport::Deprecations` but
is much pared-down in functionality. Notably, it does not currently
output the relevant part of the stacktrace that is referencing the
error.
    @michaelherold
    michaelherold committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    85dd1e3 View commit details
    Browse the repository at this point in the history

  3. rubocop: Metrics/LineLength, Layout/AlignArguments

    @technoweenie
    technoweenie committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    654338c View commit details
    Browse the repository at this point in the history

  4. rubocop: Style/Documentation 

    No clue why it's complaining here, and not every other file in 
lib/faraday :/
    @technoweenie
    technoweenie committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    43eb30f View commit details
    Browse the repository at this point in the history

  5. prefer Regexp#match, #match? was added in Ruby 2.4

    @technoweenie
    technoweenie committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    c5cb6a5 View commit details
    Browse the repository at this point in the history