Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default adapter options #1382

Merged
merged 6 commits into from
Jan 15, 2022

Conversation

hirasawayuki
Copy link
Contributor

Description

Add option for the default adapter.

Fixes #1073

Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @hirasawayuki, thanks for opening this PR.
I'm not against this addition, but we obviously need to make the CI pass first 😄.
I've left a couple of comments on how to achieve that. Unfortunately, I can't test them myself now but I hope they'll at least nudge you in the right direction 👍

@hirasawayuki hirasawayuki requested a review from iMacTia January 15, 2022 11:43
Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙌 💯

@iMacTia iMacTia merged commit 7f00491 into lostisland:main Jan 15, 2022
@hirasawayuki hirasawayuki deleted the add-default-adapter-options branch January 15, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapter's extra options within assignment default_adapter
2 participants