Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection#build_exclusive_url: replace simple syntax #1481

Merged

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Jan 13, 2023

Description

apply the advice about Connection#build_exclusive_url's syntax in #1349 (comment)

On a side note, the regex to check for a trailing slash here could be replaced with a simple base.path.end_with?('/') which probably is faster and more readable. Also here there's a direct call to URI.parse instead of Utils.URI(...) circumventing the custom URL parser.

Todos

List any remaining work that needs to be done, i.e:

  • Tests
  • Documentation

Additional Notes

Optional section

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and small!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants