Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Ruby 3.4.0-preview1 #1560

Conversation

m-nakamura145
Copy link
Contributor

Description

This PR deals with Ruby 3.4's backtrace incompatibility introduced at ruby/ruby#9608.
https://bugs.ruby-lang.org/issues/16495

❯ ruby -v
ruby 3.4.0preview1 (2024-05-16 master 9d69619623) [x86_64-darwin23]

  1) Faraday proxies to default_connection uses method_missing on Faraday if there is no proxyable method
     Failure/Error: expect { Faraday.this_method_does_not_exist }.to raise_error(NoMethodError, expected_message)

       expected NoMethodError with "undefined method `this_method_does_not_exist' for module Faraday", got #<NoMethodError: undefined method 'this_method_does_not_exist' for module Faraday> with backtrace:
         # ./lib/faraday.rb:147:in 'Faraday.method_missing'
         # ./spec/faraday_spec.rb:28:in 'block (4 levels) in <top (required)>'
         # ./spec/faraday_spec.rb:28:in 'block (3 levels) in <top (required)>'
     # ./spec/faraday_spec.rb:28:in 'block (3 levels) in <top (required)>'

Todos

List any remaining work that needs to be done, i.e:

  • Tests
  • Documentation

Additional Notes

Optional section

@iMacTia
Copy link
Member

iMacTia commented May 24, 2024

I'm not entirely sure how this test didn't fail sooner in main against ruby-head, but since it's passing fine here, I think there's no problem to get this merged 😄
Thanks 🙇 !

@iMacTia iMacTia merged commit 6d82d71 into lostisland:main May 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants