Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generic argument forwarding + remove ruby2_keywords #1601

Merged

Conversation

chaymaeBZ
Copy link
Contributor

@chaymaeBZ chaymaeBZ commented Nov 25, 2024

Description

Use generic argument forwarding (...) and remove ruby2_keywords as it is not needed.
This makes it much faster as it does not need to allocate.
This is also a step forward complete removal of ruby2_keywords.

Additional Notes

Can't do the same for the adapter method as it throws a syntax error with ruby 3.0.0.

Code/faraday/lib/faraday/rack_builder.rb:109: syntax error, unexpected (...
  ...dapter(klass = NO_ARGUMENT, ...)
 ...                             ^~~

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @chaymaeBZ! This streamlines these methods, and takes us into the present!

@olleolleolle olleolleolle merged commit f9f4ce5 into lostisland:main Nov 26, 2024
7 checks passed
@chaymaeBZ chaymaeBZ deleted the use-generic-argument-forwarding branch November 26, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants