Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support IPv6 addresses in the :net_http adapter #621

Closed
wants to merge 3 commits into from
Closed

Support IPv6 addresses in the :net_http adapter #621

wants to merge 3 commits into from

Commits on Oct 20, 2016

  1. Support IPv6 addresses in the :net_http adapter 

    Fixes lostisland#589.

The problem comes from Net::HTTP not being able to understand brackets
when passed a literal IPv6 address:

    Net::HTTP.start("[::1]") #=> :(
    Net::HTTP.start("::1") #=> :)

URI provides two different methods to extract the network host from the
URI: #host, and #hostname.

The only difference being that `#hostname` will unwrap brackets for IPv6
addresses, which is what we want here.
    @foca
    foca committed Oct 20, 2016
    Configuration menu
    Copy the full SHA
    65eb777 View commit details
    Browse the repository at this point in the history

  2. IPv6 test for adapters

    @foca
    foca committed Oct 20, 2016
    Configuration menu
    Copy the full SHA
    63f0ebf View commit details
    Browse the repository at this point in the history

  3. Test IPv6 requests for adapters that support it

    @foca
    foca committed Oct 20, 2016
    Configuration menu
    Copy the full SHA
    30b7298 View commit details
    Browse the repository at this point in the history