Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting min/max SSL version for a Net::HTTP connection on Ruby 2.5 #792

Merged
merged 1 commit into from
May 1, 2018

Conversation

bdewater
Copy link
Contributor

@bdewater bdewater commented Apr 24, 2018

The functionality in the OpenSSL gem was introduced in ruby/openssl#142 and supported by Net::HTTP in Ruby 2.5: ruby/ruby@dcea919

An example why this might be useful; for payment data the PCI DSS mandates that TLS 1.1 or newer is used after June 30. Using ssl_version would disallow the client negotiating TLS 1.2 (or 1.3 in the near future) if both sides support it, min_version doesn't have this problem.

@iMacTia
Copy link
Member

iMacTia commented Apr 25, 2018

Hi @bdewater, this makes sense, but unfortunately it won't work unless you add the new fields to the SSLOptions class.
Travis is in fact failing with the error: NameError: no member 'min_version' in struct

@bdewater
Copy link
Contributor Author

bdewater commented Apr 25, 2018

Hey @iMacTia thanks for the pointer, I didn't have the time to dig into it yesterday but CI is green now 😄

@iMacTia iMacTia merged commit e7c7990 into lostisland:master May 1, 2018
@bdewater bdewater deleted the ssl-minmax-version branch May 1, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants