-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brotli support #134
Add brotli support #134
Conversation
Want to add brotli support. See lostisland/faraday_middleware#134
Hi @jabley, I'm really sorry your PR went ignored for so long! |
I'll see if the brotli gem will accept a pull request to support < Ruby 2.x. |
Want to see if they'll take a PR which adds 1.9 support. See lostisland/faraday_middleware#134
If there are problems with that, what's your support policy on 1.9.3? It's been EOLed for quite a while. |
The idea is that we keep supporting as many ruby versions as possible, depending on how this impact our work. Reality is that even though 1.9.3, 2.0 and 2.1 have been discontinued, there are still many "legacy" applications using them. I understand On the other hand, we can't keep supporting ancient ruby versions. That's why we'll definitely abandon 1.9.3 with the release of Faraday v1.0. I think a major release is the perfect time to decide which rubies we should support and which we shouldn't. My initial plan was to just drop 1.9.3, but given that 2.0 and 2.1 are both already EOL, we might think to push the threshold even further. In short, I appreciate you trying to add support for 1.9.3 on brotli and I'll be happy to merge this in for release 0.13.0 if that happens. However, should that not be the case, we can simply move your PR against the v1.0 branch 👍 |
It is done. 😀 |
Brotli is a new open-source compression algorithm from Google which can give more dense compression, while compression and decompression speeds are roughly the same. Brotli responses are requested by setting `Accept-Encoding: br`. Transferring less data over the network will typically result in a faster experience for users. This change adds support for Brotli decompression of responses.
Great work in maintaining support for ruby 1.9.3. |
Brotli is a new open-source compression algorithm from Google which can
give more dense compression, while compression and decompression speeds
are roughly the same.
Brotli responses are requested by setting
Accept-Encoding: br
.Transferring less data over the network will typically result in a
faster experience for users.
This change adds support for Brotli decompression of responses.