Add LICENSE file to NuGet pkg #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostromb
reviewed
Mar 21, 2024
lostromb
requested changes
Mar 21, 2024
There was a problem hiding this comment.
Ideally I would like to also use nuget licensing expressions to label this declaratively, like <license type="expression">BSD-3-Clause</license>
I was planning to overhaul packaging soon anyways in the modernize branch... But this will work for now. Just fix the xml syntax
lostromb
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PackageLicenseUrl property has been deprecated.
Instead we are supposed to use
PackageLicenseExpressionorPackageLicenseFilenow.This PR replaces
PackageLicenseUrlwithPackageLicenseFileand includes the license file in the NuGet package, as required by this license.