Fix various minor bugs #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
lostromb
commented
May 4, 2024
•
lostromb
commented
- In certain conditional code paths, sample rate and channel count was not being set on the multistream decoder.
- Addressed warnings where Span was compared to null
- More explicit handling of the FEC Decode case where you're supposed to pass a null input as a Span parameter - in this case, Span.Empty is acceptable.
- Update the public interface to expose the GetVersionString() method
- Recompiled native lib for win-x64 and win-x86 to address a possible AVX2 misalignment issue
…s no other clear way to expose what implementation you're using. Recompiling win-x64 and win-x86 native binaries to circumvent an AVX2 alignment issues that was recently fixed in libopus. Bumping nuget version to 2.1.2 and updating internal version strings.
…ing Span<> to null. Condition the IsAotCompatible tag to the .NetCore export only.
lostromb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.