Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handlebars as peer dependency #8

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

yanneves
Copy link
Contributor

Installing this library without handlebars leads to a Module not found error. Good use-case for npm peer dependencies.

@yanneves
Copy link
Contributor Author

Any chance of an update for this PR?

@kennethormandy
Copy link
Contributor

Hey there—I was previously under the impression that peerDependencies were getting removed in npm@3 so I didn’t make that change #4 (comment). It seems like I might have been wrong about that, and they just aren’t automatically installed with npm@3 anymore?

If that’s the case, I can merge this and tag a new release.

@yanneves
Copy link
Contributor Author

Hey, I can understand the confusion, you're correct, the npm v3 release changes may offer a bit of clarity..

npm/npm#6930 (npm/npm#6565) peerDependencies no longer cause anything to be implicitly installed

That means on install, this plugin will warn if Handlebars is missing, but won't install Handlebars automatically or limit the install to any particular semver versions. It's designed precisely for this use-case.

@kennethormandy kennethormandy merged commit 3f4ac47 into losttype:master Mar 22, 2017
@kennethormandy
Copy link
Contributor

Tagged as v0.3.0, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants