Translation support rework #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice work! |
These 2 strings are a duplicate of existing ones (which should reduce translation boilerplate a bit)
This will make adding a new translation a bit easier (this change also accepts full codes for language variations like en-UK or pt-BR) Also specify a full code for English and Chinese translations (Chinese variation was found with a translation tool's language detector so it might not be accurate)
This removes all of the boilerplate for setting strings (now the strings are set by looping through an object and calling a helper function) The helper function also has an English string fallback if a translation doesn't have one And finally some functions/.html code were adjusted to simplify the localization helper function (this also means innerHTML is no longer used for safety)
There's some strings coming from the Rust side though (which will require extra code work)
This may be strange in some places though
TheComputerGuy96
force-pushed
the
klaipeda
branch
from
b008c56 to
255786b
Compare
|
Sorry for the late response, but this is really great - thank you very much for your effort! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a Lithuanian translation (it may not be the best though)